composefs: prefer std library functions #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
we use "ro" in composefs as well: https://github.com/containers/composefs/blob/main/libcomposefs/lcfs-mount.c#L582-L585, but MS_RDONLY should be enough |
avoid dealing directly with file descriptors but use the standard library functions. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
composefs-reduce-unix-pkg-usage
branch
from
232a788
to
39098fb
Compare
|
opened a PR for composefs as well: containers/composefs#309 @cgwalters PTAL |
cgwalters
approved these changes
Jul 30, 2024
| // do not worry about checking the magic number, if the file is invalid | ||
| // we will fail to mount it anyway | ||
| flags := make([]byte, 4) | ||
| nread, err := unix.Pread(fd, flags, 8) |
There was a problem hiding this comment.
I don't really care too much, but I would note that I think we could use https://pkg.go.dev/os#File.ReadAt here instead
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mtrmac
reviewed
Jul 30, 2024
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a couple of cleanups for the composefs backend