test/system: Rewrite a test using the standard Bats helpers #1506
Conversation
The extra debug logs from 'toolbox --verbose' are not needed for the test case to work, and other tests don't gratuitously use --verbose either. Fallout from 55b5018 containers#1506
debarshiray
force-pushed
the
wip/rishi/test-system-sudo-id-rewrite
branch
from
2270836
to
8fbd601
Compare
The test was earlier rewritten in commit b0beb68 with custom code in the hope that it would make it more reliable. The test has proven to be reliable in recent times, and the cause for its past unreliability is unclear. Therefore, it will be better to remove the custom code in favour of the standard Bats helpers for the sake of consistency and readability. Until Bats 1.10.0, 'run --keep-empty-lines' had a bug where it counted the trailing newline on the last line as a separate line [1]. However, Bats 1.10.0 is only available in Fedora >= 39 and is absent from Fedora 38. [1] Bats commit 6648e2143bffb933 bats-core/bats-core@6648e2143bffb933 bats-core/bats-core#708 containers#1506
|
Build succeeded. ✔️ unit-test SUCCESS in 7m 09s |
|
Build succeeded. ✔️ unit-test SUCCESS in 6m 40s |
No description provided.