Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace /usr/local/sbin/unminimize with unminimize in apt #1567

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Replace /usr/local/sbin/unminimize with unminimize in apt #1567

merged 1 commit into from
Oct 21, 2024

Conversation

tom-reinders
Copy link
Contributor

Fixes #1566

/usr/local/sbin/unminimize has been remove and has been replaced with unminimize in apt

docker-library/official-images#17708 (comment)
https://discourse.ubuntu.com/t/oracular-oriole-release-notes/44878#unminimize-33

@tom-reinders tom-reinders mentioned this pull request Oct 17, 2024
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/d5c6112c13f7412c8bbb53c77ba3ee00

✔️ unit-test SUCCESS in 5m 46s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 56s
✔️ unit-test-restricted SUCCESS in 5m 16s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 26m 19s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 13m 44s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 38m 37s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 22m 10s
❌ system-test-fedora-41-runtime-environment TIMED_OUT in 1h 45m 22s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 23m 48s
❌ system-test-fedora-40-runtime-environment TIMED_OUT in 1h 45m 21s
✔️ system-test-fedora-39-commands-options SUCCESS in 1h 23m 40s
❌ system-test-fedora-39-runtime-environment TIMED_OUT in 1h 45m 22s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/5b3cc271e628470ebd0d0903a2169b75

✔️ unit-test SUCCESS in 5m 49s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 54s
✔️ unit-test-restricted SUCCESS in 5m 54s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 14m 04s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 20m 57s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 33m 06s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 14m 12s
❌ system-test-fedora-41-runtime-environment TIMED_OUT in 1h 45m 24s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 14m 09s
❌ system-test-fedora-40-runtime-environment TIMED_OUT in 1h 45m 22s
✔️ system-test-fedora-39-commands-options SUCCESS in 1h 13m 21s
✔️ system-test-fedora-39-runtime-environment SUCCESS in 1h 43m 52s

Jmennius
Jmennius approved these changes Oct 18, 2024
View reviewed changes
.github/workflows/ubuntu-images.yaml Outdated Show resolved Hide resolved
@Jmennius
Copy link
Collaborator

I've reworded and squashed commits, removed .idea gitignore.
This is good to go IMO.

@Jmennius Jmennius requested a review from travier October 20, 2024 21:02
@Jmennius Jmennius self-assigned this Oct 20, 2024
@Jmennius
Copy link
Collaborator

Hmm, looking at how Github notifies about scheduled workflows...

Notifications for scheduled workflows are sent to the user who initially created the workflow. If a different user updates the cron syntax in the workflow file, subsequent notifications will be sent to that user instead. If a scheduled workflow is disabled and then re-enabled, notifications will be sent to the user who re-enabled the workflow rather than the user who last modified the cron syntax.

So if I want to receive notification I should be the one to be the last editor or enabled of the workflow... this is hilarious, there is no way to set it as a configuration.
I'm thinking, with your permission, I can change the authorship on that commit that touches the workflow... but then there is another PR that will soon touch it again :(

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/819dbbec81de430788da88a570f50eb4

✔️ unit-test SUCCESS in 5m 46s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 07s
✔️ unit-test-restricted SUCCESS in 5m 49s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 27m 24s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 39m 48s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 41m 21s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 30m 06s
❌ system-test-fedora-41-runtime-environment TIMED_OUT in 1h 45m 25s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 31m 00s
❌ system-test-fedora-40-runtime-environment TIMED_OUT in 1h 45m 30s
✔️ system-test-fedora-39-commands-options SUCCESS in 1h 31m 59s
❌ system-test-fedora-39-runtime-environment TIMED_OUT in 1h 45m 20s

@tom-reinders @Jmennius
images: ubuntu: 24.04: Fix missing unminimize script
8eb198d 
`unminimize` has been moved to a dedicated package:
https://discourse.ubuntu.com/t/oracular-oriole-release-notes/44878#unminimize-33

Fixes: containers#1566
Signed-off-by: Tom Reinders <t.reinders@recognize.nl>
@tom-reinders
Copy link
Contributor Author

@Jmennius Where has the fail-fast: false gone?

@Jmennius
Copy link
Collaborator

@Jmennius Where has the fail-fast: false gone?

I'll add it to another PR :) In a minute

@Jmennius Jmennius merged commit 3496110 into containers:main Oct 21, 2024
8 of 9 checks passed
@Jmennius Jmennius mentioned this pull request Oct 21, 2024
Merged
@tom-reinders tom-reinders deleted the fix-1566 branch October 21, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jmennius Jmennius Jmennius approved these changes

@HarryMichal HarryMichal Awaiting requested review from HarryMichal

@debarshiray debarshiray Awaiting requested review from debarshiray

@travier travier Awaiting requested review from travier

Assignees

@Jmennius Jmennius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ubuntu-toolbox 24.04 build is broken and image is missing from quay.io repo
2 participants
@tom-reinders @Jmennius