Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency containers/automation_images to v20240529 - abandoned #139

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 4, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
containers/automation_images major 20231208t193858z-f39f38d13 -> 20240529t141726z-f40f39d13

Release Notes

containers/automation_images (containers/automation_images)

v20240529t141726z-f40f39d13

Compare Source

v20240513t140131z-f40f39d13

Compare Source

v20240320t153921z-f39f38d13

Compare Source

v20240125t184057z-f39f38d13

Compare Source

v20240102t155643z-f39f38d13

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies label Mar 4, 2024
@renovate renovate bot requested a review from cevich March 4, 2024 17:13
@renovate renovate bot changed the title chore(deps): update dependency containers/automation_images to v20240125 chore(deps): update dependency containers/automation_images to v20240320 Mar 21, 2024
@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch from 9d78ffa to 8ce5892 Compare March 21, 2024 12:43
@renovate renovate bot changed the title chore(deps): update dependency containers/automation_images to v20240320 chore(deps): update dependency containers/automation_images to v20240513 May 13, 2024
@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch from 8ce5892 to 8c3ce30 Compare May 13, 2024 20:35
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot changed the title chore(deps): update dependency containers/automation_images to v20240513 chore(deps): update dependency containers/automation_images to v20240529 May 29, 2024
@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch from 8c3ce30 to 9cf62af Compare May 29, 2024 19:07
@cevich
Copy link
Member

cevich commented May 29, 2024

@wrabcak @janzarsky PTAL, seems like something is breaking after an update to Fedora 40.

@cevich
Copy link
Member

cevich commented May 29, 2024

Just took a look at the build script, we're installing fuse3 and fuse3-devel maybe something else is missing or was dropped?

Fixes:
podman run -d -v /home:/home:ro -v /var/spool:/var/spool:rw -p 21:21 fedora sleep 1h  # ./contrib/cirrus/test.sh:11 in main()
Error: configure storage: overlay: can't stat program "/usr/bin/fuse-overlayfs": faccessat /usr/bin/fuse-overlayfs: no such file or directory

Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
@vmojzis
Copy link
Collaborator

vmojzis commented May 30, 2024

@cevich Thank you for looking into it. Installing fuse-overlayfs seems to fix it (#140), just not sure why it's necessary. It should be installed as a weak dependency of podman.

Copy link
Contributor Author

renovate bot commented May 30, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@vmojzis
Copy link
Collaborator

vmojzis commented May 30, 2024

@cevich I'll merge this and #133 if you don't have any objections.

@cevich
Copy link
Member

cevich commented May 30, 2024

It should be installed as a weak dependency of podman.

Ahh, I vaguely recall a change in this area. I'll followup with the team to confirm the dependencies are as intended.

I'm cool with #140 if you want to re-open and merge. It seems to fix the issue.

Edit: Nevermind, I see you added those changes here. The dependency was definitely removed between F39 and F40. I'm confirming with the team to see what we want to do here.

@cevich
Copy link
Member

cevich commented May 30, 2024

@wrabcak or @rhatdan either of you have an opinion here? I'm okay with installing the package to run the tests, but I wonder what's the user experience? Maybe should the Udica pckage(?) have a dependency added for fuse-overlayfs?

@wrabcak
Copy link
Member

wrabcak commented May 30, 2024

There should be no connection between fuse-overlayfs and udica packages. I believe this is dependency from podman.

@renovate renovate bot changed the title chore(deps): update dependency containers/automation_images to v20240529 chore(deps): update dependency containers/automation_images to v20240529 - abandoned May 30, 2024
Copy link
Contributor Author

renovate bot commented May 30, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@vmojzis
Copy link
Collaborator

vmojzis commented May 30, 2024

Merged.

@vmojzis vmojzis closed this May 30, 2024
@cevich
Copy link
Member

cevich commented May 30, 2024

I believe this is dependency from podman.

That's exactly my concern. I believe it was dropped for podman.

@vmojzis
Copy link
Collaborator

vmojzis commented May 30, 2024

@cevich Yes, but podman is using the dependency. It has nothing to do with udica (it was podman usage in the test that triggered the issue) so it doesn't make sense to add the dependency here.
The commit removing the dependency from podman says that overlayfs is required by containers-common. The problem is that containers-common only "Suggests" it, while podman used to "Recommend" it and AFAIK hints are ignored by dnf by default.

@cevich
Copy link
Member

cevich commented May 31, 2024

it was podman usage in the test that triggered the issue

Oooohhh, that's the piece I was missing. Dan also looked into this and sounded okay with how things are currently setup. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants