This repository has been archived by the owner on Apr 3, 2018. It is now read-only.
Revert "Merge pull request #584 from amshinde/switch-to-scsi" #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Hi @sboeuf - I see that this is a test PR, but please can you explain why this revert is needed? In fact, could you raise an issue with full details? |
|
@jodh-intel yes that was a test PR, let me talk with @amshinde before we take a decision about this. |
|
@jodh-intel We are seeing some random failures with hotplug test for virtio-scsi: |
|
The issue was due to an old version of agent being used in our CI. We can close this now. I have rerun CI for this VC PR: #649 |
|
@amshinde sounds good to me :) |
|
#649 passed as expected, let's close this then ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 494b46c, reversing
changes made to e475a8f.
THIS IS A TEST PR.