This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
Fix goroutine leak in websocket #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3co-code
approved these changes
Feb 7, 2018
|
@marco-jantke good idea, we will push 1.5.2 next week so that's all good :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a leak in websocket
To explain:
We have two goroutines, one for the connection with the backend, and one for the connection with the client.
If an error occurs on one of the goroutines, we close both connection. By buffering the err channel, we can ignore the error on the goroutine which occurs because we close the connection intentionally.