-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: regex container name filtering #1241
feat: regex container name filtering #1241
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Should we merge it or leave it? |
Sorry Mateusz, I've been preoccupied with other things for a while. Will have a look as soon as time allows. Thank you for your contribution. 🙏🏼 |
Codecov Report
@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
+ Coverage 62.70% 64.55% +1.84%
==========================================
Files 23 23
Lines 1488 1560 +72
==========================================
+ Hits 933 1007 +74
+ Misses 471 464 -7
- Partials 84 89 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Soo, to make this change backwards-compatible, we need to ensure that the whole name matches the regex, otherwise we would have containers which included the name as a substring match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have handled the scenarios that I was worried about. @simskij ?
Thanks for merging Quick question, will there be a release any time soon? If not, I'm happy to use the dev builds in the meantime; however, those are only built for amd64 - any chance to have cross platform dev builds? Thanks |
@mateuszdrab What platform do you need? I have been piling up work for some time, so I can't give you a release date unfortunately. |
@piksel |
This small change allows the use of re2 regex in the container name filter parameter
I'm currently running this in my environment with the following cmdline
--cleanup --interval 21600 -d \/[^k][^8][^s][^_][\S]+
This prevents containers belonging to K8s from being auto updated as there is no way to enforce labels correctly in K8s.
I've been running this since end of January and had no problems so far - thought it would be nice to PR this.