Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifier): don't panic on unconfigured notifier #869

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Mar 30, 2021

When notifications is populated, but the corresponding options for configuring the notifications are not provided watchtower currently panics when trying to write out what notifications it uses.
This will instead simply print none, which is much more helpful.

Fixes #867

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@da56c21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage        ?   45.40%           
=======================================
  Files           ?       24           
  Lines           ?     1381           
  Branches        ?        0           
=======================================
  Hits            ?      627           
  Misses          ?      688           
  Partials        ?       66           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da56c21...e1a5452. Read the comment docs.

@piksel piksel mentioned this pull request Apr 13, 2021
@simskij simskij merged commit b644ec6 into main Apr 18, 2021
@simskij simskij deleted the fix/notifications-without-targets branch April 18, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when shoutrrr notifications are enabled but no URLs are specified
2 participants