feat: make head pull failure warning toggleable #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #912 +/- ##
==========================================
- Coverage 45.29% 40.14% -5.16%
==========================================
Files 25 25
Lines 1402 1415 +13
==========================================
- Hits 635 568 -67
- Misses 701 785 +84
+ Partials 66 62 -4
Continue to review full report at Codecov.
|
simskij
force-pushed
the
feat/head-failure-toggle
branch
from
d878b35
to
763b412
Compare
simskij
approved these changes
Apr 21, 2021
piksel
commented
Apr 21, 2021
piksel
force-pushed
the
feat/head-failure-toggle
branch
from
b7b0784
to
3deb4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion for resolving #892.
This will add the command line argument
--warn-on-head-failure, which can be set toalways,auto(default) andnever.Where
autois the current behaviour, where registries that are known to work (and especially docker hub) will yield a warning when HEAD requests fail.Setting it to
neverdisables the warning, andalwayswarns regardless of whether the registry is known to support HEAD. The last one is mostly useful for testing is not expected to be used much for the average user.It also changes what the warnings contain. They now always include the image name and the reason for the HEAD failure.
The disabled warnings are still logged as
debug, so you can still find them in your logs if you have--debugenabled.