Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix a flappy lineage test case #58

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

LucasRoesler
Copy link
Member

Change the test logic so that we check all of the upstream fields and use sorting to ensure the test is stable.

Change the test logic so that we check all of the upstream fields and
use sorting to ensure the test is stable.

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@LucasRoesler LucasRoesler requested a review from eyelesbarrow July 3, 2023 15:39
@LucasRoesler LucasRoesler self-assigned this Jul 3, 2023
Copy link
Contributor

@eyelesbarrow eyelesbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is something i'll keep in mind in future tests with dictionaries

@LucasRoesler LucasRoesler merged commit dcf8c36 into main Jul 3, 2023
@LucasRoesler LucasRoesler deleted the fix-flappy-lineage-test-case branch July 3, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants