chore: add test for cross schema and more complex queries

datahub_sap_hana/column_lineage_schema.py

@@ -1,6 +1,7 @@
 from dataclasses import dataclass
 
 from serde import serde
+from sqlglot import expressions
 from sqlglot.lineage import Node
 
 
@@ -40,11 +41,18 @@ class ColumnField:
     dataset: Table
 
     @classmethod
-    def from_node(cls, node: Node, schema: str):
+    def from_node(cls, node: Node, default_schema: str):
         """Creates a ColumnField from a sqlglot node."""
+
+        schema = default_schema
+
+        if isinstance(node.source, expressions.Table):
+            schema = node.source.catalog or node.source.db or default_schema
+
         return cls(
             name=parse_column_name(node.name),
-            dataset=Table(schema=schema, name=node.source.name),
+            dataset=Table(
+                schema=schema, name=node.source.name),
         )
 
 

datahub_sap_hana/ingestion.py

@@ -238,14 +238,14 @@ def get_column_lineage_view_definitions(
 
         for schema_name in schema:
             if self.config.schema_pattern.allowed(schema_name):
-
                 views: List[str] = inspector.get_view_names(
                     schema=schema_name
                 )  # returns a list
 
                 for view_name in views:
                     view_sql: str = inspector.get_view_definition(
-                        view_name, schema_name)
+                        view_name, schema_name
+                    )
 
                     if view_sql:
                         yield View(
@@ -281,8 +281,8 @@ def get_column_view_lineage_elements(
         Each tuple contains a downstream field (a column in a view) and a list of
         upstream fields (columns in other views or tables that are used to
         calculate/transform the downstream column).
-        """
 
+        """
         for view in self.get_column_lineage_view_definitions(inspector):
             column_lineage: List[
                 Tuple[DownstreamLineageField, List[UpstreamLineageField]]
@@ -291,8 +291,8 @@ def get_column_view_lineage_elements(
             column_lineages = self._get_column_lineage_for_view(view.sql)
 
             downstream_table_metadata = get_table_schema(
-                inspector, view.name, view.schema)
-
+                inspector, view.name, view.schema
+            )
 
             # lineage_node represents the lineage of 1 column in sqlglot
             # lineage_node.downstream is the datahub upstream each element