Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix:** Support Layout cases where Page has no title #839

Merged
merged 1 commit into from
Nov 21, 2018
Merged

**Fix:** Support Layout cases where Page has no title #839

merged 1 commit into from
Nov 21, 2018

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Nov 20, 2018 •
edited by fabien0102
Loading

Summary

This PR adds support to Layout and Page where children are correctly spaced when Page has no given title prop.

Related issue

#834

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@TejasQ TejasQ self-assigned this Nov 20, 2018
@TejasQ TejasQ requested a review from fabien0102 November 20, 2018 23:40
@TejasQ
Copy link
Contributor Author

TejasQ commented Nov 20, 2018

Page without title are not well dimensioned

fabien0102
fabien0102 approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@fabien0102 fabien0102 merged commit 845fbd1 into master Nov 21, 2018
@fabien0102 fabien0102 deleted the fix/page-without-title branch November 21, 2018 09:52
@TejasQ TejasQ mentioned this pull request Nov 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabien0102 fabien0102 fabien0102 approved these changes

Assignees

@TejasQ TejasQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TejasQ @fabien0102