**Feature:** Add Contact component to for user metadata
#850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabien0102 your export test is 💯 🔥 |
TejasQ
force-pushed
the
feature/contact
branch
from
28ad0d0 to
054d043
Compare
fabien0102
reviewed
Dec 3, 2018
| @@ -48,12 +48,19 @@ const separatorColors = { | |||
| * A specialized color palette for typography. | |||
| */ | |||
| const textColors = { | |||
| /** `#333` */ | |||
|
It was looking so good, so I tried to challenge a bit more the component 👼
|
peterszerzo
approved these changes
Dec 3, 2018
fabien0102
previously approved these changes
Dec 3, 2018
TejasQ
force-pushed
the
feature/contact
branch
from
4e729e0 to
cabd291
Compare
added 7 commits
December 5, 2018 13:54
- Contact does not manipulate margins and correctly wraps - ContextMenu supports React Elements as label and icon props - Hint\'s API now allows moving its toolbar around - Topbar needed an update to be compatible with ContextMenu
TejasQ
force-pushed
the
feature/contact
branch
from
d95d93d to
f0e6aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a nice little component that renders a user's name and metadata for placement in various parts of our UI.
It is not tightly coupled to
Avatarand just shows contacts.To be tested
Me
localhost:6060Tester 1
Tester 2