Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix:** full screen modal height #881

Merged
merged 2 commits into from
Dec 20, 2018
Merged

**Fix:** full screen modal height #881

merged 2 commits into from
Dec 20, 2018

Conversation

fabien0102
Copy link
Contributor

Summary

The full screen modal is 20px to big, so we can scroll! (and I don't like that ^^)

Related issue

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@fabien0102 fabien0102 self-assigned this Dec 20, 2018
@fabien0102 fabien0102 requested review from micha-f and TejasQ December 20, 2018 16:21
@fabien0102 fabien0102 merged commit b784bd8 into master Dec 20, 2018
@fabien0102 fabien0102 deleted the fix-full-screen-modal-height branch December 20, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micha-f micha-f micha-f approved these changes

@TejasQ TejasQ Awaiting requested review from TejasQ

Assignees

@fabien0102 fabien0102

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabien0102 @micha-f