Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Enhance:** Add day-of-week mark to datepicker #886

Merged
merged 1 commit into from
Jan 7, 2019
Merged

**Enhance:** Add day-of-week mark to datepicker #886

merged 1 commit into from
Jan 7, 2019

Conversation

peterszerzo
Copy link
Contributor

Summary

Adding day-of-week marks to the datepicker:

screen shot 2019-01-02 at 11 25 35 am

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@peterszerzo peterszerzo requested a review from micha-f January 2, 2019 10:29
@peterszerzo peterszerzo force-pushed the feature/datepicker-weedays branch from 9c1492e to d0f2d89 Compare January 2, 2019 12:28
@peterszerzo
Copy link
Contributor Author

Add weekday letters to date picker

@micha-f
Copy link
Member

micha-f commented Jan 4, 2019

Can we use weeks starting on Monday? "According to international standard ISO 8601, Monday is the first day of the week."
We could also make it configurable but default to Monday.

@peterszerzo peterszerzo mentioned this pull request Jan 4, 2019
Closed
@peterszerzo
Copy link
Contributor Author

That makes sense @micha-f - I opened #887 for it, I'll tackle it in a different PR so this one can stay purely visual.

TejasQ
TejasQ approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for one small observation.

src/DatePicker/DatePicker.styles.ts
isDisabled?: boolean
isPlaceholder?: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? I don't get this change. It just moved down? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shuffled things around thinking I would refactor, but decided not to.

@peterszerzo peterszerzo merged commit 72b8891 into master Jan 7, 2019
@peterszerzo peterszerzo deleted the feature/datepicker-weedays branch January 7, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TejasQ TejasQ TejasQ approved these changes

@micha-f micha-f Awaiting requested review from micha-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterszerzo @micha-f @TejasQ