Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix**: Remove unnecessary button margin #893

Merged
merged 2 commits into from
Jan 18, 2019
Merged

**Fix**: Remove unnecessary button margin #893

merged 2 commits into from
Jan 18, 2019

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Jan 18, 2019 •
edited
Loading

Summary

This PR removes an unnecessary right margin on Button. (#892)

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@TejasQ TejasQ self-assigned this Jan 18, 2019
@TejasQ TejasQ changed the title **Fix** #892: Removes unnecessary button margin **Fix**: Removes unnecessary button margin Jan 18, 2019
@TejasQ TejasQ changed the title **Fix**: Removes unnecessary button margin **Fix**: Remove unnecessary button margin Jan 18, 2019
stereobooster
stereobooster approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@stereobooster stereobooster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added small comment. Otherwise ok

@TejasQ TejasQ merged commit ad9a58f into master Jan 18, 2019
@TejasQ TejasQ deleted the fix/button-margin branch January 18, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereobooster stereobooster stereobooster approved these changes

@fabien0102 fabien0102 Awaiting requested review from fabien0102

Assignees

@TejasQ TejasQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TejasQ @stereobooster