**Feature:** Full Size Pages #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return ( | ||
| <Modal> | ||
| {modal => ( | ||
| <Confirm> | ||
| {confirm => ( | ||
| <Container> | ||
| <StyledPageContent {...props} fill_={fill}> | ||
| <StyledPageContent {...props} noPadding={Boolean(noPadding)} fill_={Boolean(fill)}> |
There was a problem hiding this comment.
Something disturbing me about noPadding, but I can't clearly understand what.
When I think about positioning and abstractions around it I remember this talk https://www.deconstructconf.com/2017/kevin-lynagh-choosing-features.
There was a problem hiding this comment.
@stereobooster I'm following the convention introduced by @fabien0102 in #890.
stereobooster
approved these changes
Jan 18, 2019
fabien0102
reviewed
Feb 7, 2019
| padding: `${props.theme.space.element}px`, | ||
| return { | ||
| gridTemplateColumns, | ||
| display: props.fill_ ? "block" : "grid", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
Pageto allow truly FULL SIZE options (for Pantheon query editors).To be tested
Me
localhost:6060Tester 1
Tester 2