Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Feature:** Add tabs to CardColumn #896

Merged
merged 3 commits into from
Jan 25, 2019
Merged

**Feature:** Add tabs to CardColumn #896

merged 3 commits into from
Jan 25, 2019

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Jan 25, 2019

Summary

This PR adds tabs to CardColumn in order to implement the following design:

image

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@TejasQ TejasQ self-assigned this Jan 25, 2019
fabien0102
fabien0102 approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🌮

@TejasQ TejasQ merged commit 91d4a8e into master Jan 25, 2019
@TejasQ TejasQ deleted the feature/card-column-tabs branch January 25, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereobooster stereobooster stereobooster left review comments

@fabien0102 fabien0102 fabien0102 approved these changes

Assignees

@TejasQ TejasQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TejasQ @stereobooster @fabien0102