Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix:** Update Sidenav props to be normal #901

Merged
merged 1 commit into from
Jan 28, 2019
Merged

**Fix:** Update Sidenav props to be normal #901

merged 1 commit into from
Jan 28, 2019

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Jan 28, 2019

Summary

For some reason, the Sidenav has a weird children definition.

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@TejasQ TejasQ self-assigned this Jan 28, 2019
@TejasQ TejasQ merged commit 3004976 into master Jan 28, 2019
@TejasQ TejasQ deleted the fix/sidenav-type branch January 28, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereobooster stereobooster stereobooster approved these changes

@fabien0102 fabien0102 Awaiting requested review from fabien0102

Assignees

@TejasQ TejasQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TejasQ @stereobooster