Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix:** form and form elements #906

Merged
merged 13 commits into from
Feb 1, 2019
Merged

**Fix:** form and form elements #906

merged 13 commits into from
Feb 1, 2019

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Feb 1, 2019 •
edited
Loading

Summary

This PR:

  • Fixes LabelText to have a correct line-height
  • Improves Switch to layout options if specified
  • Fixes the outdated README of Select
  • Fixes incorrect layout handling on Input
  • Fixes the layout of Form groups
  • Fixes the z-index and layout of Autocomplete

Tester 1

  • Things look good on the demo.

@TejasQ TejasQ self-assigned this Feb 1, 2019
@TejasQ TejasQ changed the title Fix form and form elements **Fix:** form and form elements Feb 1, 2019
@fabien0102
Copy link
Contributor

Looks nice, can you publish a canary version so I can try in my app 😃

stereobooster
stereobooster reviewed Feb 1, 2019
View reviewed changes
src/Form/README.md Outdated Show resolved Hide resolved
stereobooster
stereobooster approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@stereobooster stereobooster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout looks ok

@TejasQ TejasQ merged commit 2389509 into master Feb 1, 2019
@TejasQ TejasQ deleted the fix/form branch February 1, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micha-f micha-f micha-f left review comments

@stereobooster stereobooster stereobooster approved these changes

@fabien0102 fabien0102 Awaiting requested review from fabien0102

Assignees

@TejasQ TejasQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TejasQ @fabien0102 @stereobooster @micha-f