**Breaking:** Remove deprecated constants #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejasQ
commented
Feb 21, 2019
|
This example is broken, even on master, let's remove the old API 😅 |
|
This should be green |
|
The toggle switch is broken |
fabien0102
previously requested changes
Feb 22, 2019
|
I think we need a thorough review of all components before we can merge this. @fabien0102 did you go through all components? Or is your feedback just the result of a quick check? |
TejasQ
force-pushed
the
remove-deprecated-constants
branch
from
95628ce to
4b2656b
Compare
TejasQ
force-pushed
the
remove-deprecated-constants
branch
from
817b699 to
c1b18c0
Compare
TejasQ
force-pushed
the
remove-deprecated-constants
branch
from
c1b18c0 to
e23fdbf
Compare
stereobooster
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE @micha-f and @contiamo/frontend, spend a few minutes and go through each component to see which sizes/paddings/etc. broke.
The components whose snapshots changed need extra attention.
It may be helpful to have (side by side) the PR preview and
master. I am doing the same.This PR removes all of the unnecessary dead weight in the library.
Related issue
To be tested
Me
localhost:6060Tester 1
Tester 2