**Fix:** it was not possible to disable Tree component inside CardSection #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stereobooster
commented
Mar 7, 2019
| @@ -43,10 +43,11 @@ export type OverlayType = "noOverlay" | "disabled" | DragAndDropFeedback | |||
| * The flex rule only kicks in when the parent is flex-positioned in case | |||
| * sections are stacked horizontally. | |||
| */ | |||
| const Container = styled("div")` | |||
| const Container = styled("div")<{ disabled?: boolean }>` | |||
There was a problem hiding this comment.
Maybe we need to add aria-disabled
TejasQ
previously approved these changes
Mar 7, 2019
| @@ -43,10 +43,11 @@ export type OverlayType = "noOverlay" | "disabled" | DragAndDropFeedback | |||
| * The flex rule only kicks in when the parent is flex-positioned in case | |||
| * sections are stacked horizontally. | |||
| */ | |||
| const Container = styled("div")` | |||
| const Container = styled("div")<{ disabled?: boolean }>` | |||
| @@ -161,7 +162,7 @@ const CardSection: React.SFC<CardSectionProps> = ({ | |||
| forceToggleHoverStyles, | |||
| ...props | |||
| }) => ( | |||
| <Container {...props}> | |||
| <Container {...props} disabled={disabled}> | |||
There was a problem hiding this comment.
Suggested change
| <Container {...props} disabled={disabled}> | |
| <Container {...props} disabled={disabled} aria-disabled={disabled}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
N/A
To be tested
Me
localhost:6060Tester 1
Tester 2