**Feature:** Hotkey hook #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejasQ
suggested changes
Mar 11, 2019
src/useHotkey/README.md
Outdated
| const useRef = require("react").useRef | ||
|
|
||
| const Component1 = () => { | ||
| const scope = useRef(null) |
There was a problem hiding this comment.
Let's use containerNode here.
src/useHotkey/useHotkey.test.tsx
Outdated
| // Meta | ||
| fireEvent(rendered, new KeyboardEvent("keydown", { key: "o", metaKey: true })) | ||
| expect(callbackCtrl.mock.calls.length).toBe(1) | ||
| expect(callbackShift.mock.calls.length).toBe(1) |
There was a problem hiding this comment.
To have been called with autocomplete
TejasQ
approved these changes
Mar 11, 2019
mpotomin
force-pushed
the
use-hotkey-hook
branch
from
f2d2838 to
3bdb652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a hook, that allows intercepting a hotkey combination in an HTML element and triggering a callback in reponse
Related issue
PAN-33
To be tested