Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Breaking:** Make error message inline instead of floating #959

Merged
merged 3 commits into from
Mar 13, 2019
Merged

**Breaking:** Make error message inline instead of floating #959

merged 3 commits into from
Mar 13, 2019

Conversation

stereobooster
Copy link
Contributor

Summary

Before:

Screenshot 2019-03-13 at 12 06 48

After:
Screenshot 2019-03-13 at 12 06 55

Related issue

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@stereobooster stereobooster self-assigned this Mar 13, 2019
TejasQ
TejasQ suggested changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I FREAKING LOVE IT

Let's clarify a couple things in comments but it's so perfect

src/Textarea/Textarea.tsx Outdated Show resolved Hide resolved
src/Textarea/Textarea.tsx Show resolved Hide resolved
TejasQ
TejasQ approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 😍

@TejasQ TejasQ merged commit 49bdef2 into master Mar 13, 2019
@TejasQ TejasQ deleted the refactor-textarea branch March 13, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TejasQ TejasQ TejasQ approved these changes

@fabien0102 fabien0102 Awaiting requested review from fabien0102

Assignees

@stereobooster stereobooster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stereobooster @TejasQ