Render Markdown Codeblocks that contain code #2880
Open
+95
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes markdown codeblock rendering when they contain code
Approach
Detect the beginning of markdown code blocks and replace their ```s with ~~~s
People will be copying the code block with no backticks in the vast majority of cases anyways, not the entire generated output
Notes
Benchmarked at sub-millisecond or around 1ms for longer outputs
Doesn't work if language isn't specified in codeblocks, but usually it is
Doesn't work if tildes or more than 3 backticks are used in top-level markdown block, which is an extreme edge case
I wrote a version that does achieve that and included commented out, didn't use for performance/complexity concerns. It essentially predicts if it's another start/end codeblock based on if there's a new line after the ticks or not, but it doesn't work well mid-generation
Checklist