Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't override embeddings model name with UNSPECIFIED #3313

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: don't override embeddings model name with UNSPECIFIED #3313

merged 1 commit into from
Dec 11, 2024

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Dec 11, 2024

Fixes #3312

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit bc79388
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/675975413570910008abfe99

@fbricon
fix: don't override embeddings model name with UNSPECIFIED
bc79388 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon
Copy link
Contributor Author

fbricon commented Dec 11, 2024

I dunno if the forced model: "rerank-2" from 5a1bb2d#diff-2cb932451d95e56151c82e9433db890e0b6e801d1cd3930acdd48fbd5f430c27R493 is problematic, so didn't touch it.
Let me know if something similar should be done there.

@sestinj sestinj merged commit 5da2c50 into continuedev:main Dec 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sestinj sestinj sestinj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: embeddings model always overridden by 'UNSPECIFIED'
2 participants
@fbricon @sestinj