Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-conventional: Remove support for the "improvement" type #898

Closed
1 task done
gavinsharp opened this issue Jan 17, 2020 · 0 comments · Fixed by #899
Closed
1 task done

config-conventional: Remove support for the "improvement" type #898

gavinsharp opened this issue Jan 17, 2020 · 0 comments · Fixed by #899

Comments

@gavinsharp
Copy link
Contributor

Expected Behavior

Commit messages that use the "improvement" type should be rejected when using the @commitlint/config-conventional config.

Current Behavior

"improvement" was allowed in #832

Affected packages

  • config-conventional

Context

This caused unexpected behaviour in our app because commitlint allowed the commit, but semantic-release does not recognize that commit type, so it did not generate a release.

commitizen also reverted their addition of this type: https://github.com/commitizen/conventional-commit-types/pull/16/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant