Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support improvement commit type #149

Closed
wants to merge 1 commit into from

Conversation

skeggse
Copy link
Contributor

@skeggse skeggse commented Nov 1, 2019

This commit type is supported by commitizen via commitizen/conventional-commit-types#13, though it's not officially part of the conventionalcommits spec as of v1.0.0 (it was previously included in v1.0.0-beta4).

It'd be nice to find consensus on whether this type is valid under the conventionalcommits - feel free to push back on this changeset, and I can instead suggest a revert to commitizen/conventional-commit-types#13.

@pvdlg
Copy link
Member

pvdlg commented Nov 2, 2019

That doesn't seems to be part of the spec and it looks like it's a commitizen only decision to add this type. The conventional-changelog preset doesn't implement it: https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-changelog-conventionalcommits/writer-opts.js#L162

If it were to be supported by conventional-changelog-conventionalcommits we would add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants