Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releaseCommitMessageFormat Support #350

Closed
jbottigliero opened this issue May 8, 2019 · 0 comments · Fixed by #351
Closed

releaseCommitMessageFormat Support #350

jbottigliero opened this issue May 8, 2019 · 0 comments · Fixed by #351
Labels
bug

Comments

@jbottigliero
Copy link
Member

jbottigliero commented May 8, 2019 •
edited
Loading

This is a bit of a cross-repo (the change will likely occur in the conventionalcommits preset) ticket.

releaseCommitMessageFormat is not currently supported by the preset/standard-version. I've linked a PR with a failing test.

It seems like the fix will be to convert releaseCommitMessageFormat the message property in the preset loader, but going that route does seem to couple the preset and standard-version in a not-so-obvious way. Added to standard-version by aliasing --message.
@jbottigliero jbottigliero mentioned this issue May 8, 2019
Merged
jbottigliero pushed a commit that referenced this issue May 10, 2019
fix: adds support for releaseCommitMessageFormat
b3f5dee 
- adds support for `releaseCommitMessageFormat` from the spec via `--message` alias
- adds test covering: .versionrc, new --releaseCommitMessageFormat flag, and current --message flag

resolves #350
jbottigliero pushed a commit that referenced this issue May 14, 2019
@jbottigliero
fix: adds support for releaseCommitMessageFormat
a6f816b 
- adds support for `releaseCommitMessageFormat` from the spec via `--message` alias
- adds test covering: .versionrc, new --releaseCommitMessageFormat flag, and current --message flag

resolves #350
@bcoe bcoe closed this as completed in #351 May 14, 2019
@escapedcat escapedcat mentioned this issue Sep 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adds support for releaseCommitMessageFormat conventional-changelog/standard-version
1 participant
@jbottigliero