Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds support for releaseCommitMessageFormat #351

Merged
merged 3 commits into from
May 14, 2019
Merged

fix: adds support for releaseCommitMessageFormat #351

merged 3 commits into from
May 14, 2019

Conversation

jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented May 8, 2019 •
edited
Loading

  • adds support for releaseCommitMessageFormat from the spec via --message alias
  • adds test covering: .versionrc, new --releaseCommitMessageFormat flag, and current --message flag

resolves #350

@bcoe
Copy link
Member

bcoe commented May 9, 2019

@jbottigliero this is looking good to me, perhaps keep this open and we can include the fix?

@jbottigliero
Copy link
Member Author

@bcoe – yup! Grabbing this one now.

@jbottigliero jbottigliero changed the title test: adds failing test for 'releaseCommitMessageFormat' fix: adds support for releaseCommitMessageFormat May 10, 2019
@jbottigliero jbottigliero requested a review from bcoe May 10, 2019 02:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b3f5dee on fix-releaseCommitMessageFormat into a5ac845 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b3f5dee on fix-releaseCommitMessageFormat into a5ac845 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b3f5dee on fix-releaseCommitMessageFormat into a5ac845 on master.

@coveralls
Copy link

coveralls commented May 10, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling ab7e1da on fix-releaseCommitMessageFormat into 73b35f8 on master.

bcoe
bcoe reviewed May 10, 2019
View reviewed changes
command.js Outdated Show resolved Hide resolved
@jbottigliero
Copy link
Member Author

See #359 for the warning...

@bcoe
Copy link
Member

bcoe commented May 14, 2019

@jbottigliero mind rebasing this, this looks great to me.

jbottigliero and others added 3 commits May 14, 2019 15:13
@jbottigliero
test: adds failing test for 'releaseCommitMessageFormat'
6ccf909
@jbottigliero
fix: adds support for releaseCommitMessageFormat
a6f816b 
- adds support for `releaseCommitMessageFormat` from the spec via `--message` alias
- adds test covering: .versionrc, new --releaseCommitMessageFormat flag, and current --message flag

resolves #350
@jbottigliero
fix: adds warning for -m and --message (#359)
ab7e1da
@jbottigliero jbottigliero force-pushed the fix-releaseCommitMessageFormat branch from fdd71f6 to ab7e1da Compare May 14, 2019 20:20
@jbottigliero
Copy link
Member Author

@bcoe – updated, should be good to go.

@bcoe bcoe merged commit a7133cc into master May 14, 2019
@bcoe bcoe deleted the fix-releaseCommitMessageFormat branch May 14, 2019 22:14
@bcoe
Copy link
Member

bcoe commented May 14, 2019

@jbottigliero thank you!

@rklec rklec mentioned this pull request Mar 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe left review comments

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

releaseCommitMessageFormat Support
3 participants
@jbottigliero @bcoe @coveralls