Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumpfiles example uses "file" not "filename" #504

Closed
mtfurlan opened this issue Dec 13, 2019 · 2 comments · Fixed by #527
Closed

bumpfiles example uses "file" not "filename" #504

mtfurlan opened this issue Dec 13, 2019 · 2 comments · Fixed by #527

Comments

@mtfurlan
Copy link

In the Can I use standard-version for additional metadata files, languages or version files? section of the README the .versionrc example uses file instead of filename.

I installed standard-version with npm i -g standard-version@next and have version 7.1.0.

When the .versionrc refers to file, it prints this and returns 1.

The "path" argument must be of type string. Received type undefined
roschaefer added a commit to roschaefer/standard-version that referenced this issue Jan 16, 2020
@roschaefer
docs(configuration): Fix typo & required versions
3a9b721 
I've spend at least an hour to figure out why my configuration files were always ignored. After debugging the source of my `node_modules/standard-version/*` it turns out I had `7.0.1` installed which apparently does not have the feature of `bumpFiles` or `packageFiles`.

I don't understand why `7.0.1` and not `7.1.0` got installed. I used `yarn add --dev standard-version`.

close conventional-changelog#504 conventional-changelog#271
@roschaefer roschaefer mentioned this issue Jan 16, 2020
Merged
jbottigliero pushed a commit that referenced this issue Jan 20, 2020
@roschaefer @jbottigliero
docs(Configuration): Fix typo, adds required version for custom versi…
3904075 
…on file management and references proper attribute name (`filename`) (#527)

> I've spend at least an hour to figure out why my configuration files were always ignored. After debugging the source of my `node_modules/standard-version/*` it turns out I had `7.0.1` installed which apparently does not have the feature of `bumpFiles` or `packageFiles`.
> I don't understand why `7.0.1` and not `7.1.0` got installed. I used `yarn add --dev standard-version`. 
@roschaefer 

Closes #504, #271
@jbottigliero
Copy link
Member

Hi, we've updated the documentation to reflect the proper attribute – thanks!

@thattomperson
Copy link

Hey, This is still incorrect in the readme on https://www.npmjs.com/package/standard-version
is there some other step to update the readme on there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(configuration): Fix typo & required versions roschaefer/standard-version
3 participants
@jbottigliero @thattomperson @mtfurlan