-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add other artifacts to the release commit #96
Comments
Been looking at using standard-version for videojs. We basically do this for pre-build bundles for bower users or other users who don't want to use a bundler. |
@bcoe @gkatsev @JaKXz Is there still a need for a hook between
I'm not against supporting a "lifecycle-hook" between the add and commit/tag (e.g. |
I think that
Then when npm's versioning runs, it just commits the entire thing. |
Great! I think this issue can technically be closed, since you can commit any artifacts built before |
Actually we should keep this issue open to track documentation relating to this use-case. |
|
...actually, I may have spoken too soon. I had to add the built assets to the release commit myself. |
Yes, currently the commit-all flag just commits already staged changes. That might seem confusing, but I actually think it allows for greater control over the process. Needs to be clear in the documentation though. I'll take a look at the pr soon when I'm on my comp. |
See: conventional-changelog/standard-version#96 Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
ATM, I'm amending because I want the produced artifacts to be part of the
chore(release): x.x.x
commit.However, because of the way git works this creates a new commit object since the original commit is tagged before the amend happens. What would be nice is if my
postrelease
script was really apoststandard-version
script (i.e. a "lifecycle-style" hook like the npm run script itself).cc @stevemao @bcoe
The text was updated successfully, but these errors were encountered: