Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct changelog spelling in header #316

Closed
wants to merge 1 commit into from

Conversation

cristovaov
Copy link

@cristovaov cristovaov commented Mar 25, 2019

In my opinion this is just a spelling mistake and not a breaking change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bca0b05 on cristovaov:patch-1 into aad6a61 on conventional-changelog:master.

@stevemao stevemao requested a review from bcoe March 26, 2019 02:16
@jbottigliero
Copy link
Member

Going to link this to #299 for tracking, but this looks good to me.

@bcoe
Copy link
Member

bcoe commented Apr 4, 2019

@cristovaov I kind of think this is a point of opinion, looking at:

https://keepachangelog.com/en/0.3.0/

They use the term Change Log throughout the site ... what if you instead refactor it so that you can pass in the header in configuration?

@cristovaov
Copy link
Author

cristovaov commented Apr 4, 2019

@bcoe I'd respectfully argue why I believe (or opine) change log to be a spelling mistake :)

They've passed to 1.0.0 for while now: https://keepachangelog.com/en/1.0.0/
where all references to "change log" were changed to "changelog" in that version.
I've looked up what was grammarly correct but admit that it's somewhat inconclusive dictionary wise:

  1. The Free Dictionary:
  2. Mirriam-Webster has no entry for 'changelog' nor 'change log'.
  3. Oxford Dictionary:

This said, I'm not sure if I'm knowledgeable enough to make the header configurable. I could give it a go at the weekend perhaps!

edit: fixed a sentence

@bcoe
Copy link
Member

bcoe commented May 5, 2019

addressed in #335, you convinced me of the spelling 😄

@bcoe bcoe closed this May 5, 2019
@cristovaov
Copy link
Author

Thank you @bcoe !

@cristovaov cristovaov deleted the patch-1 branch May 5, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants