Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove broken interpolation #13

Merged
merged 1 commit into from
Apr 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
app: example
```

You will need to set the `CONVOX_PASSWORD` environment variable on your project to your Convox deploy key.

## See Also

https://circleci.com/orbs/registry/orb/convox/orb
Expand Down
11 changes: 1 addition & 10 deletions orb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: 2.1

description: |
Deploy applications to Convox
You must set your Convox deploy key as a project environment variable CONVOX_PASSWORD

display:
home_url: https://convox.com
Expand Down Expand Up @@ -52,10 +53,6 @@ executors:
commands:
deploy:
parameters:
deploy-key:
description: Deploy Key - https://docs.convox.com/console/deploy-keys
type: string
default: "$CONVOX_DEPLOY_KEY"
app:
description: Application Name
type: string
Expand All @@ -73,18 +70,13 @@ commands:
- run:
name: Deploy Application
environment:
CONVOX_PASSWORD: << parameters.deploy-key >>
CONVOX_HOST: << parameters.host >>
CONVOX_RACK: << parameters.rack >>
command: convox deploy --app << parameters.app >>

jobs:
deploy:
parameters:
deploy-key:
description: Deploy Key - https://docs.convox.com/console/deploy-keys
type: string
default: "$CONVOX_DEPLOY_KEY"
app:
description: Application Name
type: string
Expand All @@ -101,7 +93,6 @@ jobs:
steps:
- checkout
- deploy:
deploy-key: << parameters.deploy-key >>
app: << parameters.app >>
rack: << parameters.rack >>
host: << parameters.host >>