Merge pull request #256 from convoyinc/nevir/selective-freeze

Freeze snapshot values, but not the read cache
convoyinc · Dec 15, 2017 · 5e2b760 · 5e2b760
2 parents f1cea35 + cde4782
commit 5e2b760
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/GraphSnapshot.ts b/src/GraphSnapshot.ts
@@ -1,3 +1,5 @@
+import deepFreeze = require('deep-freeze-strict');
+
 import { NodeSnapshot } from './nodes';
 import { QueryResult, QueryResultWithNodeIds } from './operations/read';
 import { NodeId, OperationInstance } from './schema';
@@ -57,4 +59,13 @@ export class GraphSnapshot {
     return Object.keys(this._values);
   }
 
+  /**
+   * Freezes the snapshot (generally for development mode)
+   *
+   * @internal
+   */
+  freeze(): void {
+    deepFreeze(this._values);
+  }
+
 }
diff --git a/src/operations/SnapshotEditor.ts b/src/operations/SnapshotEditor.ts
@@ -1,5 +1,4 @@
 import { isEqual } from 'apollo-utilities';
-import deepFreeze = require('deep-freeze-strict');
 
 import { CacheContext } from '../context';
 import { InvalidPayloadError, OperationError } from '../errors';
@@ -442,7 +441,7 @@ export class SnapshotEditor {
 
     const snapshot = this._buildNewSnapshot();
     if (this._context.freezeSnapshots) {
-      deepFreeze(snapshot);
+      snapshot.freeze();
     }
 
     return {