-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement connection directive #319
base: master
Are you sure you want to change the base?
Implement connection directive #319
Conversation
8f0eaa2
to
06f5df2
Compare
06f5df2
to
805e42b
Compare
Sorry, probably going to be a few more days before I can get around to taking a look at this one :( |
all good at your own time! thanks for building the entire cache ;) also I imagine you'll want to provide feedback on how we should update the cache — right now I am just overwriting with the new result, 0 smarts. It would be great for application developers to be able add their own "Custom directive handlers" (like Relay Handlers that contain information on how to update and read from the cache but I'm not certain how to go about implementing this if you have any ideas. |
Depending on what you're trying to achieve - you might be able to implement your directive handlers as ApolloLinks (the cache gets attached to the link context, IIRC) |
Also, I know it's not well documented yet - but take a look at Hermes' entity updaters as well: https://github.com/convoyinc/apollo-cache-hermes/blob/master/src/context/CacheContext.ts#L98-L108 |
@nevir Any update on when this can be merged? |
Apologies! I know I've severely dropped the ball on this one :(
Hesitant to give an ETA - and I've been hesitant to merge because I don't
know the @connection spec well enough yet to have a good opinion on it
Considering merging it with a cursory review. Would you folk be ok with
helping support issues related to if they come up?
…On Tue, Jun 26, 2018, 8:49 PM Hammad Jutt ***@***.***> wrote:
@nevir <https://github.com/nevir> Any update on when this can be merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#319 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAChnWGUEAPdkz62cT-hMX3at6U6Z0DHks5uAwCvgaJpZM4SXzS6>
.
|
updated
buildFieldArgs
to now resolve correctly for theconnection
directivesolves: #289