Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connection directive #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bennyhobart
Copy link

@bennyhobart bennyhobart commented Mar 1, 2018

updated buildFieldArgs to now resolve correctly for the connection directive
solves: #289

@bennyhobart bennyhobart force-pushed the feature/connection-directive-support branch from 8f0eaa2 to 06f5df2 Compare March 1, 2018 06:02
@bennyhobart bennyhobart force-pushed the feature/connection-directive-support branch from 06f5df2 to 805e42b Compare March 1, 2018 06:12
@bennyhobart
Copy link
Author

@nevir

@nevir
Copy link
Contributor

nevir commented Mar 5, 2018

Sorry, probably going to be a few more days before I can get around to taking a look at this one :(

@bennyhobart
Copy link
Author

bennyhobart commented Mar 7, 2018

all good at your own time! thanks for building the entire cache ;) also I imagine you'll want to provide feedback on how we should update the cache — right now I am just overwriting with the new result, 0 smarts.

It would be great for application developers to be able add their own "Custom directive handlers" (like Relay Handlers that contain information on how to update and read from the cache but I'm not certain how to go about implementing this if you have any ideas.

@nevir
Copy link
Contributor

nevir commented Mar 7, 2018

Depending on what you're trying to achieve - you might be able to implement your directive handlers as ApolloLinks (the cache gets attached to the link context, IIRC)

@nevir
Copy link
Contributor

nevir commented Mar 7, 2018

Also, I know it's not well documented yet - but take a look at Hermes' entity updaters as well:

https://github.com/convoyinc/apollo-cache-hermes/blob/master/src/context/CacheContext.ts#L98-L108

@META-DREAMER
Copy link

@nevir Any update on when this can be merged?

@nevir
Copy link
Contributor

nevir commented Jun 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants