Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store coverage config in setup.cfg #2533

Merged

Conversation

danihodovic
Copy link
Contributor

@danihodovic danihodovic commented Apr 12, 2020

Less is more. Unify tooling configuration in one file.

https://coverage.readthedocs.io/en/v4.5.x/config.html

Less is more. Unify tooling configuration in one file.
@browniebroke
Copy link
Member

I'm in favour of reducing the number of config files, so sounds good to me 👍

One thing I learned recently is that the latest version also supports pyproject.toml as config file, which seems to become the new standard. Although it's not supported by all tools yet (at least mypy isn't). Anyway, this looks good.

@browniebroke browniebroke merged commit 9b6d29d into cookiecutter:master Apr 13, 2020
@danihodovic
Copy link
Contributor Author

One thing I learned recently is that the latest version also supports pyproject.toml as config file, which seems to become the new standard. Although it's not supported by all tools yet (at least mypy isn't). Anyway, this looks good.

Funny that you mention it. I was thinking about opening a PR for migrating to pyproject.toml (and using Poetry). While the community seems to be moving in that direction, it's not supported yet for mypy and pytest. We would end up in a strange intermediary state where we use pyproject.toml, but still maintain additional config files.

Let's wait until the major projects move to pyproject.toml before starting this effort.

@danihodovic danihodovic deleted the store-coveragerc-in-setup.cfg branch April 13, 2020 12:20
@browniebroke
Copy link
Member

Yes, agree. Especially since after writing the above, I discovered that adding support in flake8 is on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants