Fix OfflineGenerationError with Heroku + Django Compressor #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browniebroke
commented
May 1, 2020
browniebroke
force-pushed
the
2581-heroku-compressor-error
branch
from
0daaebd
to
d91f968
Compare
browniebroke
force-pushed
the
2581-heroku-compressor-error
branch
from
d91f968
to
68116dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
post_compilebuild hook to run offline compression when using Heroku + Django Compressor. The hook is copying what we do in Docker currently, and should be removed as soon as either Heroku or compressor are deselected.Rationale
Fixes #2581