Fix for gulp watching on windows #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for browsersync and file watchers not working correctly on windows.
browniebroke
approved these changes
Jun 29, 2020
|
@Tusky For the CONTRIBUTOR's doc, RST hyperlinks work by having the `@Tusky`_ with the link to your GitHub. You can take a look below all the names in the table to know what I mean. |
Thank you, forgot to add it at the bottom :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for browsersync and file watchers not working correctly on windows. This uses a legacy polling method, so it registers events if the user is on windows (which I assume the windows? is meant to represent.
Fixes #2642 which I've encountered.
Rationale
There are some windows developers around, and cookiecutter-django is a great start for a project whatever OS you use.
Use case(s) / visualization(s)
Not much to visualize sadly, but I think it's a pretty simple PR to understand what it does :)