-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions on how to set up a secure development environment to the documentation #2664
Conversation
UPDATING the master.
UPDATING the repo.
Merge from Pydanny
UPDATE from pydanny:master
Update to Django 3
The link was broken as it was pointing to a non-existent page.
Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
Thanks @browniebroke for having a look at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition, @Afrowave
As a side note for next time, could you please use a feature branch (as opposed to using master in your fork) to send your pull request? That would avoid the extra commits that we can see in here, like the one from #2661. |
@browniebroke I don't believe this is necessary since django-allauth doesn't require social login capabilities to be in an HTTPS local machine environment ref #2759 which raised this methodology. I haven't tested a social login with Facebook's OAuth2 capabilities, but AFAIK with Stripe and other OAuth apps, this isn't necessary and the docs might be suggesting something that's not really suitable for the local development environment. |
I am sorry, @browniebroke, I meant to get round to this and fix it now that the docs run in a docker container. I will fix this and also write a blog post to this. I have given myself the task of amintaining this part of the docs. I actually thought I had set up notifications. I hope that is okay with you. |
Description
Facebook have moved their users to secure by default.
Rationale
If a developer chooses to build Facebook login capability with the
users
app, then settinghttps
in the developer environment will be necessary.If required, I can add this capability through a new PR so that it becomes part of the project configuration.