Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions on how to set up a secure development environment to the documentation #2664

Merged
merged 13 commits into from
Aug 14, 2020

Conversation

Afrowave
Copy link
Contributor

@Afrowave Afrowave commented Jul 6, 2020

Description

Facebook have moved their users to secure by default.

Rationale

If a developer chooses to build Facebook login capability with the users app, then setting https in the developer environment will be necessary.

If required, I can add this capability through a new PR so that it becomes part of the project configuration.

Afrowave and others added 2 commits August 14, 2020 01:00
Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
@Afrowave
Copy link
Contributor Author

Thanks @browniebroke for having a look at this.

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, @Afrowave

@browniebroke browniebroke merged commit cac78de into cookiecutter:master Aug 14, 2020
@browniebroke
Copy link
Member

As a side note for next time, could you please use a feature branch (as opposed to using master in your fork) to send your pull request? That would avoid the extra commits that we can see in here, like the one from #2661.

@browniebroke browniebroke changed the title ADD instructions on how to set up a secure development environment. Add instructions on how to set up a secure development environment to the documentation Aug 14, 2020
@Andrew-Chen-Wang
Copy link
Contributor

@browniebroke I don't believe this is necessary since django-allauth doesn't require social login capabilities to be in an HTTPS local machine environment ref #2759 which raised this methodology. I haven't tested a social login with Facebook's OAuth2 capabilities, but AFAIK with Stripe and other OAuth apps, this isn't necessary and the docs might be suggesting something that's not really suitable for the local development environment.

@Afrowave
Copy link
Contributor Author

I am sorry, @browniebroke,

I meant to get round to this and fix it now that the docs run in a docker container. I will fix this and also write a blog post to this. I have given myself the task of amintaining this part of the docs.

I actually thought I had set up notifications. I hope that is okay with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants