Traeffik and Django dockerfile changes #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld make it consistent with the python version used across the app.
…t project creation time.
… with directory copying step.
…reation and file permissions steps together. If anyone fails, the entire build should fail anyway.
…traeffik-dockerfile-changes
…ng Run commands as well as changing owneship while copying files.
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce the number of image layers and speed up the build process slightly by combining varoius steps in Dockerfile into just one.
Rationale
In Django Dockerfile, I am proposing to combine ownership change step with file copying step. This would reduce the number of layers and potentially speed up the build process as well.
In Traefik Dockerfile, I am proposing to combine the 3 Run steps into 1 because if any one of them fails, the build should get aborted anyway and this would also reduce the number of layers and potentially speed up the build process as well.
Use case(s) / visualization(s)
NA