Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement v1 #32
Implement v1 #32
Changes from 55 commits
ec774fe
6bffb19
aad513e
4cfa0be
2fedcb1
65424e6
50def5f
6ea73a0
6534098
46cd60b
e991c32
fbbe06c
3a0d55c
3c22c34
5b46049
3497eda
86362c4
971e9d7
8c8de55
f8fac78
71cb9b3
01018f6
0ac49c7
5dc155e
b73597b
ab0dec7
12f5b2a
079c298
bf65480
8375c64
5c36ea4
da0c1bb
439404a
5cd183a
6635cea
5b58f3c
183329e
56af730
5bdd784
071e59f
33e3cc7
6197140
b8ef2c3
50f1046
02b8d40
a438405
34fa32c
81b7c2f
b63cd2f
a286c29
b290279
ba10fe1
9dc753c
210f8b9
5242ac1
bb17093
ac57386
cc8898a
06cdebe
5582caa
fbf518b
e017242
74de4a4
aff8056
0532c9c
4c19c12
08941a3
add26f4
7598486
c08dc72
c06fab0
013695f
888b254
a52730a
9258855
4f5fc7c
8553fbb
c72975d
59e66af
6001eaf
b385978
b9758de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO: For pull_request events, I'd like to enable concurrency.cancel-in-progress option to reduce the whole running time of the workflow. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs
So, how about separating the test steps to a composite action, and splitting the workflow into separate ones for the main branch and for pull requests? https://docs.github.com/en/actions/sharing-automations/creating-actions/creating-a-composite-action
Alternatively, you can use a trick with group names, which is described at https://stackoverflow.com/q/74117321/5989200.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: How about promoting this to an environment variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to define a repository environment variable like
RUBOCOP_RUBY_VERSION
?I think it's easier for others to understand if you write the version directly here, so I prefer this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then why did you set
RUBY_VERSION: 3.3
in integration_tests.yml? I don't have a preference for a specific method, but I would like to maintain consistency across workflow files, IMO. As unit_test.yml uses a matrix for Ruby versions, I recommended to useRUBY_VERSION
environment variable here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're seeing an old version of integration_tests.yml. The current one doesn't have
RUBY_VERSION
: https://github.com/cookpad/arproxy/blob/4f5fc7c3efef5ddbaf7b0dd14a951315d8295e90/.github/workflows/integration_tests.ymlAnyway, since I don't have a strong opinion about this, I added
RUBY_VERSION
to rubocop.yml: 8553fbbThis file was deleted.