Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: Let rubocop search .ruby-version file #328

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

nekketsuuu
Copy link
Contributor

Rubocop warns its TargetRubyVersion is too old, so I just removed it and let rubocop search .ruby-version.

https://docs.rubocop.org/rubocop/configuration.html#setting-the-target-ruby-version

> Otherwise, RuboCop will then check your project for a series of files where the version may be specified already. The files that will be looked for are *.gemspec, .ruby-version, .tool-versions, and Gemfile.lock.
@nekketsuuu nekketsuuu requested a review from a team February 28, 2024 04:19
Copy link
Member

@eagletmt eagletmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let rubocop search .ruby-version.

I didn't know that feature

@nekketsuuu nekketsuuu merged commit e7dd215 into master Feb 28, 2024
2 checks passed
@nekketsuuu nekketsuuu deleted the nekketsuuu-rubocop-yml branch February 28, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants