rubocop: Inherit rules from cookpad/styleguide and auto-correct all #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nekketsuuu
commented
Feb 28, 2024
nekketsuuu
commented
- Updated rubocop to the latest, and installed recommended rubocop extensions
- Applied cookpad/styleguide rules
- Refactored MaskedDatum to remove class variables
Also enable some extentions according to rubocop suggestions
- Avoid using class variables https://github.com/cookpad/styleguide/blob/master/ruby.en.md#variables - But class_attribute with the default value which is calculated using an instance method is a bit difficult - Remove cache and query directly, in order to remove both class variables and class_attributes - The calculation cost will be roughly the same
nekketsuuu
commented
Feb 29, 2024
| scope :masking_table, ->(database_name, table_name) { | ||
| masking_database(database_name) | ||
| .or(where(database_name: database_name, table_name: table_name, column_name: ANY_NAME)) | ||
| .or(where(database_name: ANY_NAME, table_name: table_name, column_name: ANY_NAME)) |
There was a problem hiding this comment.
Note that this also fixes behavior for */#{table_name}/*
mozamimy
approved these changes
Mar 3, 2024
hfm
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.