Browsing without login by setting environment variable #93
Conversation
kitsuyui
commented
Dec 9, 2017
kitsuyui
commented
- Enable readonly browsing when DMEMO_ALLOW_ANONYMOUS_TO_READ is set
- Feature Request: Browsing without login #92
| @@ -4,6 +4,9 @@ class ApplicationController < ActionController::Base | |||
| helper_method :current_user | |||
|
|
|||
| before_action :require_login | |||
| if ENV.has_key? 'DMEMO_ALLOW_ANONYMOUS_TO_READ' | |||
There was a problem hiding this comment.
DMEMO_ prefix is unneccessary.
| @favorite_tables = TableMemo.where(id: current_user.favorite_tables.pluck(:table_memo_id)) | ||
| else | ||
| @favorite_tables = [] | ||
| end |
There was a problem hiding this comment.
I want to hide favorite tables without login user.
app/views/shared/_navbar.html.haml
Outdated
| %li | ||
| = link_to google_oauth2_path(state: url_for(params.merge(only_path: true))) do | ||
| %i.fa.fa-sign-in | ||
| Login |
There was a problem hiding this comment.
I prefer Sign-in here.
dmemo using Sign-out yet https://github.com/hogelog/dmemo/pull/93/files#diff-fdf07dae26df4b84203e7a8380c4fdcaR16
app/views/users/index.html.haml
Outdated
| @@ -27,6 +27,6 @@ | |||
| - if user.admin? | |||
| %i.fa.fa-check | |||
| %td | |||
| - if current_user.editable_user?(user.id) | |||
| - if current_user and current_user.editable_user?(user.id) | |||
There was a problem hiding this comment.
I like current_user.try!(:editable_user?, user.id)
|
@hogelog |
|
@hogelog |
|
Sorry too late response. Please use context like http://www.betterspecs.org/#contexts and other specs.f |
- Enable readonly browsing when DMEMO_ALLOW_ANONYMOUS_TO_READ is set - Hide favorite tables without login user. - Update RSpec for anonymous login
kitsuyui
force-pushed
the
browsing-without-login
branch
from
5c736a2 to
c2e62c0
Compare
|
I'm sorry to have kept you waiting. I've updated the rspec and rebased these commits. (CI Hakiri shows warning because of Nokogiri v1.10.3 (CVE-2019-11068). |
