-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PrivacyInfo.xcprivacy #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be preferable to also update the ChangeLog.md.
https://github.com/cookpad/ios-twitter-image-pipeline/blob/main/CHANGELOG.md
added changelog |
@liamnichols If all is well, please merge and release as well. (I do not have the authority to proceed.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Although do we need to take efforts for the .xcprivacy file to be included in Package.swift and the Podspec somehow?
I'm not entirely sure how it all works, but I don't think adding the file alone is enough is it?
Added setting to bundle PrivacyInfo with package at c2d3a55 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
But CI failed.
The code hasn't been changed, so it was probably an unstable test to begin with.
I wanted to rerun tests but I couldn't find rerun button.
It seems like I don't have the right to run Github Actions.
I restarted the test, and gave you correct access to the repo 🙇 |
After #5 is merged, I will incorporate the latest main in this PR to support CocoaPod as well. I will change the PR to draft status until the support is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
マージします! |
ref links
https://github.com/cookpad/global-ios/issues/19954
Why
以下の制限された機能にアクセスしている為
accessing the following restricted functions
Used within a utility function (I believe it corresponds to 0A2A.1)
System boot time APIs have only one reason to support (35F9.1)