Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PrivacyInfo.xcprivacy #3

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

tera-ny
Copy link

@tera-ny tera-ny commented Jan 23, 2024

ref links

https://github.com/cookpad/global-ios/issues/19954

Why

以下の制限された機能にアクセスしている為
accessing the following restricted functions

Copy link

@toya108 toya108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

@toya108 toya108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be preferable to also update the ChangeLog.md.

https://github.com/cookpad/ios-twitter-image-pipeline/blob/main/CHANGELOG.md

@tera-ny
Copy link
Author

tera-ny commented Jan 24, 2024

added changelog
d20d6e8

@tera-ny
Copy link
Author

tera-ny commented Jan 24, 2024

@liamnichols
Please review this PR for any problems 🙏

If all is well, please merge and release as well. (I do not have the authority to proceed.)

Copy link

@liamnichols liamnichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Although do we need to take efforts for the .xcprivacy file to be included in Package.swift and the Podspec somehow?

I'm not entirely sure how it all works, but I don't think adding the file alone is enough is it?

@tera-ny
Copy link
Author

tera-ny commented Jan 26, 2024

Added setting to bundle PrivacyInfo with package at c2d3a55 🙏

Copy link

@toya108 toya108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
But CI failed.
The code hasn't been changed, so it was probably an unstable test to begin with.
I wanted to rerun tests but I couldn't find rerun button.
It seems like I don't have the right to run Github Actions.

@liamnichols
Copy link

liamnichols commented Jan 26, 2024

I restarted the test, and gave you correct access to the repo 🙇

@tera-ny
Copy link
Author

tera-ny commented Jan 26, 2024

After #5 is merged, I will incorporate the latest main in this PR to support CocoaPod as well. I will change the PR to draft status until the support is complete.

@tera-ny tera-ny marked this pull request as draft January 26, 2024 10:45
@tera-ny tera-ny marked this pull request as ready for review January 29, 2024 06:13
Copy link

@liamnichols liamnichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tera-ny
Copy link
Author

tera-ny commented Jan 29, 2024

マージします!

@tera-ny tera-ny merged commit f742fd7 into cookpad:main Jan 29, 2024
4 checks passed
@tera-ny tera-ny deleted the chore/add_PrivacyInfo branch January 29, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants