Enable to use Karpenter v1 controller policy (backport to 1.29) #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a squashed commit with changes in #371, along with some modifications to match the state of the 1.29 release branch: Enable to detach Karpenter v1beta controller policy Make v1 and v1beta policies mutually exclusive Use Karpenter v1 resources in test Revert "Make v1 and v1beta policies mutually exclusive" This reverts commit 0db1769. Separate policy documents as managed policies
This is a cherry-picked commit with changes in #372
coord-e
force-pushed
the
coord-e/backport-karpenter-v1-controller-policy-1-29
branch
from
a3daf64 to
c171d0b
Compare
|
Changes for test/cluster_test.go might be forgotten to be cherry-picked. |
|
release-1-29 branch runs tests with Karpenter 0.37.0, which does not support v1 resources, so I didn't include that change in this PR. https://github.com/cookpad/terraform-aws-eks/blob/release-1-29/test/cluster_test.go#L94 |
errm
approved these changes
Nov 6, 2024
coord-e
deleted the
coord-e/backport-karpenter-v1-controller-policy-1-29
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports changes from #371 and #372 into the 1.29 release branch.