Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change behaviour of ignoreCommitPattern to see tags on ignored commits #102

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Change behaviour of ignoreCommitPattern to see tags on ignored commits #102

merged 2 commits into from
Apr 11, 2019

Conversation

alexbumbacea
Copy link
Contributor

This solves #101

@alexbumbacea
Copy link
Contributor Author

@cookpete any thoughts on this PR?

@cookpete cookpete merged commit 3d0c5e6 into cookpete:master Apr 11, 2019
@cookpete
Copy link
Owner

Hey @alexbumbacea. Thanks for the PR! I've adjusted the logic slightly to reuse the existing filterCommits function. I also fixed a test as the commit you were testing for was being filtered out already by the check for semver commit messages. Nice work!

@cookpete
Copy link
Owner

Published in v1.12.1

@Expoverse Expoverse mentioned this pull request Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbumbacea @cookpete