Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cli option for first-parent #118

Closed
wants to merge 5 commits into from
Closed

Added cli option for first-parent #118

wants to merge 5 commits into from

Conversation

richardspence
Copy link

@richardspence richardspence commented May 30, 2019

PR for #117

Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if maybe it’d be better to include every git log argument somehow, rather then hardcoding this one?

`first-parent` needs to appear prrior to the format arg
@richardspence
Copy link
Author

richardspence commented May 30, 2019

I wonder if maybe it’d be better to include every git log argument somehow, rather then hardcoding this one?

@ljharb Yeah I thought about that as well. There are a few other git log args that seem they could be relevant like --use-mailmap but not sure how often that would come up.

If there's desire to go down that route maybe using a custom arg processor to create the array of git args see collect. The tradeoff is an extra layer of indirection / more complicated interface on the CLI.

@cookpete cookpete closed this in 68c20a8 Jul 7, 2019
@cookpete
Copy link
Owner

cookpete commented Jul 7, 2019

Added --append-git-log in 1.14.0, which lets you add whatever string you like to the git log command where commits are fetched:

auto-changelog --append-git-log "--first-parent --use-mailmap"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants