Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for including commit pattern #258

Merged
merged 10 commits into from
May 13, 2023

Conversation

rouzwelt
Copy link
Contributor

@rouzwelt rouzwelt commented Apr 10, 2023

proposing to add support for including commits pattern for changelog. with the option to make it strict with "--strict-include" to whether include merge commits or not.

if the strict flag is provided then only include based on provided regex, else include merge commits as well.

add support for whitelisting commits for changelog.
with the option to make it strict with "--strict-whitelist" to whether include merge commits in the whitelist or not.
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a term other than "whitelist" - perhaps "allowlist"?

src/commits.js Outdated Show resolved Hide resolved
@rouzwelt rouzwelt changed the title add support for whitelisting commits add support for including commit pattern Apr 10, 2023
@rouzwelt
Copy link
Contributor Author

I went with "exclude" and "include".
@ljharb let me know if it works for you or not

@rouzwelt rouzwelt requested a review from ljharb April 10, 2023 17:26
README.md Outdated Show resolved Hide resolved
src/commits.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
rouzwelt and others added 3 commits April 10, 2023 19:48
@rouzwelt rouzwelt requested a review from ljharb April 10, 2023 21:14
src/commits.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rouzwelt and others added 2 commits April 10, 2023 22:25
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@rouzwelt rouzwelt requested a review from ljharb April 10, 2023 23:30
@rouzwelt
Copy link
Contributor Author

hey man @ljharb , let me know if everything is good for this to get merged, I'll open the next PR as soon as this one gets merged. or if you'd prefer I can open the next PR to be merging into this one?

@ljharb
Copy link
Contributor

ljharb commented Apr 11, 2023

@rouzwelt i'm reviewing as an interested user, i'm not a maintainer here.

@rouzwelt
Copy link
Contributor Author

@cookpete Hey man, I guess you have already looked into this PR, so I was wondering what would be the next steps? Im hoping this can get merged if all looks ok from your side?

@rouzwelt
Copy link
Contributor Author

rouzwelt commented Apr 27, 2023

@cookpete hey man, I hope I can get a response from you regarding this PR, please let me know your thoughts about this, Im really hoping this Pr can be considered, it is really big feature that I need with this package, and I believe many others might come across needing it as well

@bombillazo
Copy link

Hey @cookpete , any chance to get a review for this PR? I'd also be interested in helping maintain this if necessary.

@rouzwelt
Copy link
Contributor Author

rouzwelt commented May 9, 2023

Hey @cookpete , any chance to get a review for this PR? I'd also be interested in helping maintain this if necessary.

thanks man for the support, let's wait and see what @cookpete thinks about this, he seems busy :D
but Im hoping we can have a resolution for this as soon as we get a response from @cookpete

@cookpete
Copy link
Owner

Thanks @rouzwelt for the PR and @ljharb for the review.

I’ve simplified the logic and renamed the option to --commit-pattern to be consistent with the other --*-pattern options.

I’ve also allowed both --commit-pattern and --ignore-commit-pattern to be used, for the rare case that you want to include a certain commit pattern and then exclude some of those commits.

Sorry for the delay! Will publish a new version shortly after I’ve skimmed through the other issues and PRs.

@cookpete cookpete merged commit 91226a7 into cookpete:master May 13, 2023
@rouzwelt
Copy link
Contributor Author

Thanks @rouzwelt for the PR and @ljharb for the review.

I’ve simplified the logic and renamed the option to --commit-pattern to be consistent with the other --*-pattern options.

I’ve also allowed both --commit-pattern and --ignore-commit-pattern to be used, for the rare case that you want to include a certain commit pattern and then exclude some of those commits.

Sorry for the delay! Will publish a new version shortly after I’ve skimmed through the other issues and PRs.

awesome man, thank you so much 🙏🏻

@bombillazo
Copy link

Epic! Thanks!

@axi92
Copy link

axi92 commented Sep 10, 2024

I checked and 2.4.0 does not have the option yet. Is there a reason why its not yet published?

@cookpete
Copy link
Owner

Is there a reason why its not yet published?

Because I forgot to publish this when I said I would (over a year ago) and then life got very busy.

Published in 2.5.0 🎉

@bombillazo
Copy link

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants